Backup my feature - #3298
Closed
TeamMasse wants to merge 40 commits into
Closed
Conversation
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
…4.0.0-rc1 chore: version bump 34.0.0 rc1
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Bump to 34.0.0 final
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: neronguyen <neronguyenvn@gmail.com>
Three distinct states are now handled correctly: - Startup / system update: the widget shows "Loading note…" while the RemoteViewsAdapter connects. updateAppWidget() sets the placeholder visible with that text on every full reset (ACTION_APPWIDGET_UPDATE). - Note refresh (edit or sync): updateSingleNoteWidgets() now sends a custom ACTION_DATA_CHANGED instead of ACTION_APPWIDGET_UPDATE. onReceive() handles this with notifyAppWidgetViewDataChanged() only, leaving the existing RemoteViews intact so the note content updates in place with no blank gap or flash. - Note missing: once onDataSetChanged() confirms getNoteById() returns null, partiallyUpdateAppWidget() sets the placeholder visible with "Note not found". When the note is found the placeholder is hidden via the same mechanism. Fixes nextcloud#1611 AI-assisted: Claude Code (Sonnet 4.6) Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
…-34.0.x [stable-34.0.x] fix: show "Loading note…" in single-note widget on boot instead of "Note not found"
…-34.0.x [stable-34.0.x] fix(branding): refresh BrandingUtil instance when color changes
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
chore: version bump 34.0.1 rc1
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
…-34.0.x [stable-34.0.x] fix(fastfile): lane test
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 347 |
| Duplication | 2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Member
|
Hi @TeamMasse The PR has conflicts, so you would need to rebase it onto latest main of the original/upstream repository, or you didn't want it to end up here (the name "backup my feature" kind of hints to that, but just a guess). Other than that: happy hacking, happy you like the notes app and work on extending it. |
Author
|
Yeah it accidentally ended up as PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🖼️ Screenshots
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)